[CAF] Bug in Framework::login -- no error processing?

[Olaf Alders]

On 9-Feb-06, at 2:31 PM, Eric Lyons wrote:

> Trying to debug why the Example code doesn't display errors on the  
> login page, I traced into CGI::Application::Framework::login to find:
>

<snip>

> and indeed, $errs is set correctly, but there's no use of this  
> variable in the rest of the login subroutine.  I.e., %tmplvars  
> never gets set with anything.
> It would appear it needs something after:
>
>    foreach my $hash ( $self->_login_tmpl_params() ) {
>        while ( my ($key, $value) = each %$hash ) {
>            $tmplvars{$key} = $value;
>        }
>    }
>
> like:
> while ( my($key,$value = each %$errs ) {
>    $tmplvars{$key} = $value;
> }
>


Eric was kind enough to supply a patch to fix this.  I've applied the  
patch to my P4 workspace (caf-alders) and submitted it.  I've tested  
it out and it does indeed fix the problem.  Is it too late to merge  
this with the 0.27 release?

O
--
Olaf Alders
olaf at vilerichard.com

http://www.vilerichard.com -- pop tunes
http://cdbaby.com/cd/vilerichard